Granular Import Export UIs #2610
Merged
+5,287
−1,154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonboiser
force-pushed
the
available-channels
branch
from
cbd1b30 to
98f4932
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2610 +/- ##
========================================
Coverage 77.65% 77.65%
========================================
Files 183 183
Lines 7034 7034
Branches 885 885
========================================
Hits 5462 5462
Misses 1397 1397
Partials 175 175
Continue to review full report at Codecov.
|
jonboiser
force-pushed
the
available-channels
branch
3 times, most recently
from
84f91b7 to
d6b4718
Compare
Put in channels available message Loop over channels Add language filter Add title filter Filter both language and title DRY up spec Add go to channel callback Update choose source modal Add non router-link link to immersive full view Wrap available channels in immersive full view Layout for filters Hide filters if there are no channels Wrap available channels in subpage-container Add language to channel metadata Move channels lists to wizard state Add ‘All Languages’ option for language filter Adjust styles Update wizard-import-source Add language to channel metadata Move styles to channel list item Update availableChannelsPage Update local export modal Stub content-node-row component
# Conflicts: # kolibri/plugins/management/assets/src/device_management/views/manage-content-page/wizards/wizard-export.vue # kolibri/plugins/management/assets/src/device_management/views/manage-content-page/wizards/wizard-import-source.vue
Add remove node action Fix state Add count updater Fix remaining space calculation Handle easier tree view annotations Handle stranger cases for selections Localize messages Refactor annotateNode Readjust to new node model Make selectedNodes getter Fix updates notifications test
More content node row behavior Handle more funky tree view cases Refactor content node spec Start content-tree-viewer State of select-all checkbox Handle select all toggles
Add path to child node annotation Rename ‘selecttopic’ event Refactor Add handlers for toggling children Remove annotateNodes in favor of annotateNode Start on showSelectContentPage action Add ContentNodeGranular Resource Poll for database import task Move wizard state Make correct request to ContentNodeGranular endpoint Add goToTopic action Add boilerplate for RemoteChannelResource Update import export flows
Refactor
Refactor Remove deprecated UIs Add boilerplate for select drive modal Rename Available channels enum
Fix stale integrations
# Conflicts: # kolibri/plugins/management/assets/src/device_management/views/manage-content-page/wizards/import-preview.vue
indirectlylit
added
TODO: needs review
jonboiser
force-pushed
the
available-channels
branch
from
3a22a56 to
1867836
Compare
jonboiser
force-pushed
the
available-channels
branch
from
1867836 to
a5c0ac8
Compare
|
addresses #2273 |
| this.crumbs = Array.from(val); | ||
| this.attachSensors(); | ||
| }, | ||
| }, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| */ | ||
| export function waitForTaskToComplete(store, taskId) { | ||
| return new Promise((resolve, reject) => { | ||
| const stopWatching = store.watch(taskList, function checkTaskProgress(tasks) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| dbPromise = downloadChannelMetadata(store); | ||
| } | ||
|
|
||
| // Hydrating the store with the Channel Metadata |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| token: '', | ||
| tokenIsBlurred: false, | ||
| tokenLookupFailed: false, | ||
| tokenNetworkError: false, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
jonboiser
force-pushed
the
available-channels
branch
from
4324dc2 to
a25bf4a
Compare
This was referenced Nov 22, 2017
indirectlylit
approved these changes
Nov 22, 2017
| <template v-if="canManageContent"> | ||
| <component v-if="pageState.wizardState.shown" :is="wizardComponent" /> | ||
| <component | ||
| v-if="wizardPageName!==''" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
jonboiser
force-pushed
the
available-channels
branch
from
a25bf4a to
f42ef22
Compare
|
In the export workflow, the logic needs to be slightly different than in the import workflows. So currently, one cannot select leaf nodes or topics that are completely installed for export. The import workflows should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Summary
Reviewer guidance
description of how to test the changes
References
when applicable, please provide:
Contributor Checklist
yarnandpip)Reviewer Checklist